WIP Add pulp-ui to pulp image #677
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdellweg
reviewed
Oct 11, 2024
|
|
||
| RUN <<EOF | ||
| if [[ "$PULP_UI_URL" ]]; then | ||
| mkdir -p /usr/share/nginx/static/pulp_ui |
There was a problem hiding this comment.
Is this the new /var/www ?
It's OK...
There was a problem hiding this comment.
Where should these files live? I was thinking I could put them in the pulp static directory (default: /var/lib/operator/static/), but I was worried if the user ran collectstatic with --clean then they would lose their UI as well.
|
|
||
| ENV PULP_UI=true |
There was a problem hiding this comment.
This should probably depend on PULP_UI_URL... Or let's just make PULP_UI_URL the env var?
| @@ -105,6 +105,17 @@ http { | |||
|
|
|||
| include pulp/*.conf; | |||
|
|
|||
| {% if ui | default(false) -%} | |||
There was a problem hiding this comment.
This could be if ui_url != ""?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's many different ways to serve these files, here's one way I chose. Would like some feedback on this approach.
TODO: